DO NOT MERGE: Parametrize all pipeline tests to run with arrow output format #2610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Label error. Requires exactly 1 of: patch, minor, major. Found: |
IvoDD
force-pushed
the
run-all-pipeline-tests
branch
2 times, most recently
from
d6e7c85 to
d7d1877
Compare
IvoDD
force-pushed
the
run-all-pipeline-tests
branch
from
d7d1877 to
8629499
Compare
IvoDD
force-pushed
the
run-all-pipeline-tests
branch
from
8629499 to
8df2f0e
Compare
IvoDD
force-pushed
the
fix-sparse-buffer-processing
branch
2 times, most recently
from
6570743 to
c8a0745
Compare
IvoDD
force-pushed
the
run-all-pipeline-tests
branch
from
8df2f0e to
7a80398
Compare
In some fairly niche cases processing pipeline can produce empty segments: - Resampling with dynamic schema - date range filter with no index values within an intersecting data key (fixed in a previous PR) We previously tried to allocate a 0 sized memory block which was raising assertions failures. This PR just skips allocating the 0 sized memory blocks and adds an arrow test to verify it works.
During symbol concat we can end up with a Segment with zero columns. Convert that to arrow gracefully. Also uncovered that arrow normalization doesn't correctly construct pandas_metadata for empty dataframes. This is also fixed and tested in this PR.
IvoDD
force-pushed
the
run-all-pipeline-tests
branch
from
7a80398 to
a0150a3
Compare
IvoDD
force-pushed
the
run-all-pipeline-tests
branch
from
a0150a3 to
052433f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...